Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(forks,base_types,types,vm): Misc changes fixes #827

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

marioevz
Copy link
Member

🗒️ Description

Mostly internal minor changes that are required for the execute command:

  • Add engine_get_payload_version method to forks
  • Add items meethod to Alloc and Storage
  • Add int_to_bytes helper
  • Add a TransactionDefaults class, from which the default values for Transaction class are derived
  • Add a _eoa_fund_amount_default attribute to Alloc where the default funding value for EOAs is stored, and can be changed in subclasses.

Skipped the changelog since these are internal changes

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes make a lot of sense to me. Some nice clean-up; enjoying the defaults.

@marioevz marioevz merged commit d343b81 into main Oct 1, 2024
5 checks passed
@marioevz marioevz deleted the misc-changes-fixes branch October 1, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants